[patch 4/7] Mark some key VFS functions as __always_inline

From: Arjan van de Ven <[email protected]>

Mark a few VFS functions as mandatory inline (based on Al Viro's
request); these must be inline due to stack usage issues during a recursive loop
that happens during the recursive symlink resolution (symlink to a symlink to 
a symlink ..)
This patch at this point does not change behavior and is for documentation purposes
only (but this changes later in the series)


Signed-off-by: Arjan van de Ven <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>

----

 fs/namei.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Index: linux-gcc.q/fs/namei.c
===================================================================
--- linux-gcc.q.orig/fs/namei.c
+++ linux-gcc.q/fs/namei.c
@@ -485,7 +485,7 @@ static struct dentry * real_lookup(struc
 static int __emul_lookup_dentry(const char *, struct nameidata *);
 
 /* SMP-safe */
-static inline int
+static __always_inline int
 walk_init_root(const char *name, struct nameidata *nd)
 {
 	read_lock(&current->fs->lock);
@@ -503,7 +503,7 @@ walk_init_root(const char *name, struct 
 	return 1;
 }
 
-static inline int __vfs_follow_link(struct nameidata *nd, const char *link)
+static __always_inline int __vfs_follow_link(struct nameidata *nd, const char *link)
 {
 	int res = 0;
 	char *name;
@@ -543,7 +543,7 @@ struct path {
 	struct dentry *dentry;
 };
 
-static inline int __do_follow_link(struct path *path, struct nameidata *nd)
+static __always_inline int __do_follow_link(struct path *path, struct nameidata *nd)
 {
 	int error;
 	void *cookie;
@@ -689,7 +689,7 @@ int follow_down(struct vfsmount **mnt, s
 	return 0;
 }
 
-static inline void follow_dotdot(struct nameidata *nd)
+static __always_inline void follow_dotdot(struct nameidata *nd)
 {
 	while(1) {
 		struct vfsmount *parent;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 4/7] Mark some key VFS functions as __always_inline
    • From: Al Viro <[email protected]>

• References:
  • [patch 1/7] Make __always_inline actually force always inlining
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: [patch 5/7] uninline capable()
• Next by Date: [patch 1/7] Make __always_inline actually force always inlining
• Previous by thread: Re: [patch 5/7] uninline capable()
• Next by thread: Re: [patch 4/7] Mark some key VFS functions as __always_inline
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]