Re: [PATCH 12/15] via-pmu: Wrap some uses of sleep_in_progress with proper ifdef's

On Thu, 2006-01-05 at 03:34 +0800, Kristian Mueller wrote:
> Hi Ben
> 
> On Mi, 2006-01-04 at 17:01 -0500, Ben Collins wrote:
> > Basically completes what's already in the rest of the driver.
> > sleep_in_progress is only defined for pm+ppc32.
> > 
> > Signed-off-by: Ben Collins <[email protected]>
> 
> We've already found a different solution to this in the Linuxppc-dev
> list.
> 
> See:
>  http://patchwork.ozlabs.org/linuxppc/patch?id=3737

That patch makes no sense. It just moves the variable out of the ifdef,
but if CONFIG_PM or CONFIG_PPC32 is not enabled, then the variable never
gets modified, and so is always 0. Why not just wrap all the code that
uses it (like my patch did)?

-- 
   Ben Collins <[email protected]>
   Developer
   Ubuntu Linux

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 12/15] via-pmu: Wrap some uses of sleep_in_progress with proper ifdef's
  - From: Kristian Mueller <[email protected]>

References:
- [PATCH 12/15] via-pmu: Wrap some uses of sleep_in_progress with proper ifdef's
  - From: Ben Collins <[email protected]>
- Re: [PATCH 12/15] via-pmu: Wrap some uses of sleep_in_progress with proper ifdef's
  - From: Kristian Mueller <[email protected]>

Prev by Date: Re: 2.6.15-rt1-sr1: xfs mount crash
Next by Date: Re: [PATCH] PXA2xx: build PCMCIA as a module
Previous by thread: Re: [PATCH 12/15] via-pmu: Wrap some uses of sleep_in_progress with proper ifdef's
Next by thread: Re: [PATCH 12/15] via-pmu: Wrap some uses of sleep_in_progress with proper ifdef's
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]