Re: [PATCH 1/4] media-radio: Pci probing for maestro radio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dnia 04-01-2006 o 10:45:32 Andrew Morton <[email protected]> napisał:

"Jiri Slaby" <[email protected]> wrote:

+	retval = video_register_device(maestro_radio_inst, VFL_TYPE_RADIO,
 +		radio_nr);
 +	if (retval) {
 +		printk(KERN_ERR "can't register video device!\n");
 +		goto errfr1;
 +	}
 +
 +	if (!radio_power_on(radio_unit)) {
 +		retval = -EIO;

Shouldn't we unregister the video device here?

Current behaviour means that device is here but not functioning properly but
we can unregister it of course because it is useless anyway ;-).

Regards
--
Adam Tlałka      mailto:[email protected]    ^v^ ^v^ ^v^
System  & Network Administration Group           ~~~~~~
Computer Center,  Gdańsk University of Technology, Poland
PGP public key:   finger [email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux