[PATCH] fix warning in 8250.c

  CC      drivers/serial/8250.o
/.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: 'transmit_chars' declared inline after being called
/.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: previous declaration of 'transmit_chars' was here

Since this function is not small, inlining effect is way below noise floor.
Let's just remove _INLINE_.
--
vda

  CC      drivers/serial/8250.o
/.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: 'transmit_chars' declared inline after being called
/.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: previous declaration of 'transmit_chars' was here


diff -urpN linux-2.6.15-rc7.src/drivers/serial/8250.c linux-2.6.15-rc7.fix/drivers/serial/8250.c
--- linux-2.6.15-rc7.src/drivers/serial/8250.c	Fri Dec 30 14:18:03 2005
+++ linux-2.6.15-rc7.fix/drivers/serial/8250.c	Sun Jan  1 16:56:17 2006
@@ -1217,7 +1217,7 @@ receive_chars(struct uart_8250_port *up,
 	*status = lsr;
 }
 
-static _INLINE_ void transmit_chars(struct uart_8250_port *up)
+static void transmit_chars(struct uart_8250_port *up)
 {
 	struct circ_buf *xmit = &up->port.info->xmit;
 	int count;

---

• Follow-Ups:
  • Re: [PATCH] fix warning in 8250.c
    • From: Russell King <[email protected]>

• Prev by Date: Re: flow chart tool?
• Next by Date: mm/rmap.c negative page map count BUG.
• Previous by thread: [PATCH] fix readw/writew warning in sata_vsc
• Next by thread: Re: [PATCH] fix warning in 8250.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]