Re: [PATCH 1/2]MSI(X) save/restore for suspend/resume

[Shaohua Li <shaohua.li@intel.com>]

On Wed, 2005-12-28 at 16:25, Arjan van de Ven wrote:
> On Wed, 2005-12-28 at 09:24 +0800, Shaohua Li wrote:
> > On Tue, 2005-12-27 at 15:55, Arjan van de Ven wrote:
> > > > diff -puN include/linux/pci.h~msi_save_restore include/linux/pci.h
> > > > --- linux-2.6.15-rc5/include/linux/pci.h~msi_save_restore	2005-12-22 09:23:16.000000000 +0800
> > > > +++ linux-2.6.15-rc5-root/include/linux/pci.h	2005-12-22 09:23:16.000000000 +0800
> > > > @@ -135,6 +135,7 @@ struct pci_dev {
> > > >  	unsigned int	block_ucfg_access:1;	/* userspace config space access is blocked */
> > > >  
> > > >  	u32		saved_config_space[16]; /* config space saved at suspend time */
> > > > +	void		*saved_cap_space[PCI_CAP_ID_MAX + 1]; /* ext config space saved at suspend time */
> > > >  	struct bin_attribute *rom_attr; /* attribute descriptor for sysfs ROM entry */
> > > >  	int rom_attr_enabled;		/* has display of the rom attribute been enabled? */
> > > 
> > > 
> > > void feels like sort of the wrong thing here....
> > So what is good to you :)?
> 
> doesn't it contain u16's ?
It might contain u16 or u32 or anything else. And depends on the
specific capability.

Thanks,
Shaohua

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/