Re: [patch 5/9] mutex subsystem, core

[Ingo Molnar <mingo@elte.hu>]

* Oleg Nesterov <oleg@tv-sign.ru> wrote:

> > +	/*
> > +	 * Lets try to take the lock again - this is needed even if
> > +	 * we get here for the first time (shortly after failing to
> > +	 * acquire the lock), to make sure that we get a wakeup once
> > +	 * it's unlocked. Later on this is the operation that gives
> > +	 * us the lock. If there are other waiters we need to xchg it
> > +	 * to -1, so that when we release the lock, we properly wake
> > +	 * up the other waiters:
> > +	 */
> > +	old_val = atomic_xchg(&lock->count, -1);
> > +
> > +	if (unlikely(old_val == 1)) {
> > +		/*
> > +		 * Got the lock - rejoice! But there's one small
> > +		 * detail to fix up: above we have set the lock to -1,
> > +		 * unconditionally. But what if there are no waiters?
> > +		 * While it would work with -1 too, 0 is a better value
> > +		 * in that case, because we wont hit the slowpath when
> > +		 * we release the lock. We can simply use atomic_set()
> > +		 * for this, because we are the owners of the lock now,
> > +		 * and are still holding the wait_lock:
> > +		 */
> > +		if (likely(list_empty(&lock->wait_list)))
> > +			atomic_set(&lock->count, 0);
> 
> This is a minor issue, but still I think it makes sense to optimize
> for uncontended case:
> 
> 	old_val = atomic_xchg(&lock->count, 0); // no sleepers
> 
> 	if (old_val == 1) {
> 		// sleepers ?
> 		if (!list_empty(&lock->wait_list))
> 			// need to wakeup them
> 			atomic_set(&lock->count, -1);
> 		...
> 	}
>       [*]

but then we'd have to set it to -1 again, at [*], because we are now 
about to become a waiter. So i'm not sure it's worth switching this 
around.

Also, there are two uses of this codepath: first it's the 'did we race 
with an unlocker', in which case the lock is almost likely still 
contended. The second pass comes after we have woken up, in which case 
it's likely uncontended.

while we could split up the two cases and optimize each for its own 
situation, i think it makes more sense to have then unified, and thus to 
have more compact code. It's the slowpath after all.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/