RE: [PATCH 01/02] RT: add back plist docs

["Perez-Gonzalez, Inaky" <inaky.perez-gonzalez@intel.com>]

>From: Daniel Walker [mailto:dwalker@mvista.com]
>...
>--- linux-2.6.14.orig/include/linux/plist.h
>+++ linux-2.6.14/include/linux/plist.h
>@@ -1,3 +1,79 @@
>+...
>+ * This is a priority-sorted list of nodes; each node has a >= 0
>+ * priority from 0 (highest) to INT_MAX (lowest). The list itself has
>+ * a priority too (the highest of all the nodes), stored in the head
>+ * of the list (that is a node itself).

I don't have access to the real source now, but if the prio
type is an int, we maybe should change that to 'INT_MIN(highest)
to INT_MAX(lowest)', or make the prio an unsigned and range it 
0 to UINT_MAX.

>+ * Addition is O(K), removal is O(1), change of priority of a node is
>+ * O(K) and K is the number of RT priority levels used in the system.
>+ * (1 <= K <= 99)

This comment about K is kind of misleading; if I use the plist for 
things other than scheduling chores, K changes. I'd cite that as an
example, something like:

  ...K is the number of priority levels used. For example, when
  using this list type for real-time task queuing, 1 <= K <= 99.

Thanks,

-- Inaky 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/