Re: [PATCH/RFC] SPI: async message handing library update

David,

			if (t->len) {
				/* FIXME if bitbang->use_dma, dma_map_single()
				 * before the transfer, and dma_unmap_single()
				 * afterwards, for either or both buffers...
				 */

please *please* *_please_*!!! don't do it! :)
Let the controller driver do it *only in case it's not working in PIO!*

Vitaly
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2.6-git 0/4] SPI core refresh
    • From: Vitaly Wool <[email protected]>
  • [PATCH/RFC] SPI: add async message handing library to David Brownell's core
    • From: Vitaly Wool <[email protected]>
  • [PATCH/RFC] SPI: async message handing library update
    • From: Vitaly Wool <[email protected]>
  • Re: [PATCH/RFC] SPI: async message handing library update
    • From: David Brownell <[email protected]>

• Prev by Date: Re: [PATCH RT 00/02] SLOB optimizations
• Next by Date: Re: [POLL] SLAB : Are the 32 and 192 bytes caches really usefull on x86_64 machines ?
• Previous by thread: Re: [PATCH/RFC] SPI: async message handing library update
• Next by thread: 2.6.15-rc5-rt1 compile problems
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]