[RFC: 2.6 patch] Makefile: sound/ must come before drivers/

[Adrian Bunk <bunk@stusta.de>]

On Tue, Dec 20, 2005 at 08:47:09PM +0000, James Courtier-Dutton wrote:
> Linus Torvalds wrote:
> >
> >On Tue, 20 Dec 2005, Adrian Bunk wrote:
> >
> >>But the non-saa7134 access to my soundcard (e.g. rexima or xmms) is no 
> >>longer working.
> >
> >
> >Ahh. I assume it's the sequencer init etc that is missing.
> >
> >Maybe we'll just have to do the late_init thing for at least the 2.6.15 
> >timeframe.
> >
> >		Linus
> >
> 
> But that's not really a useable fix. The problem is with almost all ALSA 
> sound cards.

No, inside sound/ it's working due to the link order.

Thinking about this, what about the patch below?

I don't know whether this might break anything else, but it fixes my 
problem.

cu
Adrian


<--  snip  -->


drivers might require an already initialized sound subsystem.

Fix the link order for a static sound subsystem.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.15-rc6/Makefile.old	2005-12-20 21:53:26.000000000 +0100
+++ linux-2.6.15-rc6/Makefile	2005-12-20 21:53:42.000000000 +0100
@@ -470,7 +470,7 @@
 
 # Objects we will link into vmlinux / subdirs we need to visit
 init-y		:= init/
-drivers-y	:= drivers/ sound/
+drivers-y	:= sound/ drivers/
 net-y		:= net/
 libs-y		:= lib/
 core-y		:= usr/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/