Re: [PATCH rc6] block: Fix CDROMEJECT to work in more cases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, 20 Dec 2005, Jens Axboe wrote:
> 
> WRITEs cannot have length 0, and READs cannot as well. Since it's just
> one bit for direction, those are the rules.

Jens, your logic doesn't make sense.

There clearly _are_ commands with a 0 data-length.

And commands _have_ to be either READ or WRITE. We don't have a choice. 
ll_rw_block: blk_get_request() even has a BIG_ON() that enforces that.

So claiming that reads and writes cannot have zere data-length is INSANE.

So reads and writes HAVE to accept a zero data length. End of story. If 
there is some path in the SCSI layer that refuses it, that part must be 
fixed, or you have to add a new "NONE" (and perhaps "BOTH") direction.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux