Re: [PATCH 1/12]: MUTEX: Implement mutexes

On Sun, 18 Dec 2005, James Bottomley wrote:
> 
> Actually, I don't think you want might_sleep(): there are a few cases
> where we do an up() from under a spinlock, which will spuriously trigger
> this.  I'd suggest WARN_ON(in_interrupt()) instead.

Ahh, good point. Yes.

However, if even the arm people aren't all that interested in this, maybe 
it simply doesn't matter. A lot of other architectures either have 
"decrement in memory" or can already use ll/sc for it.

(of course, on some architectures, ll/sc is really really slow, so they 
might well prefer using a normal load and store instead).

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH 1/12]: MUTEX: Implement mutexes
    • From: Linus Torvalds <[email protected]>
  • [PATCH 0/12]: MUTEX: Introduce mutex implementation
    • From: David Howells <[email protected]>
  • [PATCH 1/12]: MUTEX: Implement mutexes
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/12]: MUTEX: Implement mutexes
    • From: Steven Rostedt <[email protected]>
  • Re: [PATCH 1/12]: MUTEX: Implement mutexes
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/12]: MUTEX: Implement mutexes
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 1/12]: MUTEX: Implement mutexes
    • From: Nicolas Pitre <[email protected]>
  • Re: [PATCH 1/12]: MUTEX: Implement mutexes
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 1/12]: MUTEX: Implement mutexes
    • From: Nicolas Pitre <[email protected]>
  • Re: [PATCH 1/12]: MUTEX: Implement mutexes
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 1/12]: MUTEX: Implement mutexes
    • From: Russell King <[email protected]>
  • Re: [PATCH 1/12]: MUTEX: Implement mutexes
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 1/12]: MUTEX: Implement mutexes
    • From: James Bottomley <[email protected]>

• Prev by Date: Re: [PATCH 13/13] [RFC] ipath Kconfig and Makefile
• Next by Date: Re: [PATCH 10/13] [RFC] ipath verbs, part 1
• Previous by thread: Re: [PATCH 1/12]: MUTEX: Implement mutexes
• Next by thread: Re: [PATCH 1/12]: MUTEX: Implement mutexes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]