On Fri, Dec 16, 2005 at 10:04:03PM -0300, Horst von Brand wrote:
> Adrian Bunk <[email protected]> wrote:
> > On Fri, Dec 16, 2005 at 03:28:40PM -0300, Horst von Brand wrote:
> > > Adrian Bunk <[email protected]> wrote:
> > > > This patch contains some documentation updates and removes some code
> > > > paths for gcc < 3.2.
> > >
> > > [...]
> > >
> > > > --- linux-2.6.15-rc5-mm3-full/arch/arm/kernel/asm-offsets.c.old 2005-12-15 13:34:55.000000000 +0100
> > > > +++ linux-2.6.15-rc5-mm3-full/arch/arm/kernel/asm-offsets.c 2005-12-15 13:35:11.000000000 +0100
> > > > @@ -27,11 +27,11 @@
> > > > * GCC 3.2.0: incorrect function argument offset calculation.
> > > > * GCC 3.2.x: miscompiles NEW_AUX_ENT in fs/binfmt_elf.c
> > > > * (http://gcc.gnu.org/PR8896) and incorrect structure
> > > > * initialisation in fs/jffs2/erase.c
> > > > */
> > > > -#if __GNUC__ < 3 || (__GNUC__ == 3 && __GNUC_MINOR__ < 3)
> > > > +#if (__GNUC__ == 3 && __GNUC_MINOR__ < 3)
> > > > #error Your compiler is too buggy; it is known to miscompile kernels.
> > > > #error Known good compilers: 3.3
> > > > #endif
> > >
> > > Better leave the original, in case some clown comes along with an ancient
> > > compiler.
> > >...
>
> > That's what the check in init/main.c is for.
>
> But in that case this is redundant, no? Or move the checks into there.
No, the kernel now generally requires gcc >= 3.2, but on arm it requires
gcc >= 3.3.
Whether the arm specifically check is in init/main.c or
arch/arm/kernel/asm-offsets.c doesn't matter, and traditionally it is at
the latter place.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
