Re: [PATCH] Input: fix an OOPS in HID driver

[Vojtech Pavlik <vojtech@suse.cz>]

On Fri, Dec 16, 2005 at 09:31:04PM -0500, Dmitry Torokhov wrote:
> Subject: 
> 
> This patch fixes an OOPS in HID driver when connecting simulation
> devices generating unknown simulation events.
> 
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

Yup, needed indeed. I'm not sure if we want an 'unknown': 'ignore'
might be safer.

> ---
> 
>  drivers/usb/input/hid-input.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> Index: work/drivers/usb/input/hid-input.c
> ===================================================================
> --- work.orig/drivers/usb/input/hid-input.c
> +++ work/drivers/usb/input/hid-input.c
> @@ -137,6 +137,7 @@ static void hidinput_configure_usage(str
>  			switch (usage->hid & 0xffff) {
>  				case 0xba: map_abs(ABS_RUDDER); break;
>  				case 0xbb: map_abs(ABS_THROTTLE); break;
> +				default:   goto unknown;
>  			}
>  			break;
>  
> 
> 

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/