Re: [PATCH] Add mem_nmi_panic enable system to panic on hard error

Alan Cox wrote:

I could find your code in the -mm tree. It looks good :-)
But just one point, isn't it better to use die_nmi() instead of panic()?

>>        if (panic_on_unrecovered_nmi)
>>                panic("NMI: Not continuing");

At the point we halt for an unrecovered NMI the call trace isnt likely
to be interesting and the message being visible is most important. I'm
not sure if die_nmi would be better therefore - dunno what other folks
think ?

Indeed, that's true.
In this case of an unrecovered NMI, the call trace is useless.
Thank you for pointing it out.

H.Seto

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Add mem_nmi_panic enable system to panic on hard error
    • From: Hidetoshi Seto <[email protected]>
  • Re: [PATCH] Add mem_nmi_panic enable system to panic on hard error
    • From: Dave Jones <[email protected]>
  • Re: [PATCH] Add mem_nmi_panic enable system to panic on hard error
    • From: Alan Cox <[email protected]>
  • Re: [PATCH] Add mem_nmi_panic enable system to panic on hard error
    • From: Hidetoshi Seto <[email protected]>
  • Re: [PATCH] Add mem_nmi_panic enable system to panic on hard error
    • From: Alan Cox <[email protected]>

• Prev by Date: Re: 2.6.14-rt21: slow-running clock
• Next by Date: [PATCH 3/13] Time: Clocksource Infrastructure
• Previous by thread: Re: [PATCH] Add mem_nmi_panic enable system to panic on hard error
• Next by thread: patch for splice system call.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]