Re: [RFC][PATCH 3/3] TCP/IP Critical socket communication mechanism

Sridhar Samudrala wrote:
> The only reason i made these macros is that i would expect this to a compile
> time configurable option so that there is zero overhead for regular users.
> 
> #ifdef CONFIG_CRIT_SOCKET
> #define SK_CRIT_ALLOC(sk, flags) ((sk->sk_allocation & __GFP_CRITICAL) | flags)
> #define CRIT_ALLOC(flags) (__GFP_CRITICAL | flags)
> #else
> #define SK_CRIT_ALLOC(sk, flags) flags
> #define CRIT_ALLOC(flags) flags
> #endif

Oh, that's much simpler to achieve:

#ifdef CONFIG_CRIT_SOCKET
#define __GFP_CRITICAL_SOCKET __GFP_CRITICAL
#else
#define __GFP_CRITICAL_SOCKET 0
#endif

Maybe we can get better naming here, but you get the point, I think.


Regards

Ingo Oeser

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH 3/3] TCP/IP Critical socket communication mechanism
    • From: Sridhar Samudrala <[email protected]>
  • Re: [RFC][PATCH 3/3] TCP/IP Critical socket communication mechanism
    • From: Alan Cox <[email protected]>
  • Re: [RFC][PATCH 3/3] TCP/IP Critical socket communication mechanism
    • From: Sridhar Samudrala <[email protected]>

• Prev by Date: [PATCH] ARM: Netwinder ds1620 driver needs an export to be built as module
• Next by Date: Re: [patch 5/6] statistics infrastructure
• Previous by thread: Re: [RFC][PATCH 3/3] TCP/IP Critical socket communication mechanism
• Next by thread: querry on DMA
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]