Re: [patch 6/6] statistics infrastructure - exploitation: zfcp

On Wed, Dec 14, 2005 at 05:14:30PM +0100, Martin Peschke wrote:
>  	if (device_register(&unit->sysfs_device)) {
> +		zfcp_unit_statistic_unregister(unit);
>  		kfree(unit);
>  		return NULL;
>  	}
> 
>  	if (zfcp_sysfs_unit_create_files(&unit->sysfs_device)) {
> +		zfcp_unit_statistic_unregister(unit);
>  		device_unregister(&unit->sysfs_device);
>  		return NULL;
>  	}

Unrelated, but doesn't that error path forget to release unit?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 6/6] statistics infrastructure - exploitation: zfcp
    • From: Martin Peschke <[email protected]>

• References:
  • [patch 6/6] statistics infrastructure - exploitation: zfcp
    • From: Martin Peschke <[email protected]>

• Prev by Date: Re: process creation time increases linearly with shmem
• Next by Date: Re: [RFC][PATCH 1/6] Create Critical Page Pool
• Previous by thread: [patch 6/6] statistics infrastructure - exploitation: zfcp
• Next by thread: Re: [patch 6/6] statistics infrastructure - exploitation: zfcp
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]