Re: [spi-devel-general] [patch 2.6.15-rc5-mm2] SPI, priority inversion tweak

[Vitaly Wool <vwool@ru.mvista.com>]

Hmm...

> -	down(&lock);
> +	/* ... unless someone else is using the pre-allocated buffer */
> +	if (down_trylock(&lock)) {
> +		local_buf = kmalloc(SPI_BUFSIZ, GFP_KERNEL);
> +		if (!local_buf)
> +			return -ENOMEM;
> +	} else
> +		local_buf = buf;
> +
>  
Okay, so suppose we have two controller drivers working in two threads 
and calling write_then_read in such a way that the one called later has 
to allocate a new buffer. Suppose also that both controller drivers are 
working in PIO mode. In this situation you have one redundant kmalloc 
and two redundant memcpy's, not speaking about overhead brought up by 
mutexes. Bad!
So I still can't say I'm accepting this approach.

Worth mentioning is that the approach I propose is free from this drawback.

Vitaly
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/