Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation

On Tue, 13 Dec 2005, Andi Kleen wrote:
> 
> Remove -Wdeclaration-after-statement

Please don't.

It's a coding style issue. We put our variable declarations where people 
can _find_ them, not in random places in the code.

Putting variables in the middle of code only improves readability when you 
have messy code. 

Now, one feature that _may_ be worth it is the loop counter thing:

	for (int i = 10; i; i--)
		...

kind of syntax actually makes sense and is a real feature (it makes "i" 
local to the loop, and can actually help people avoid bugs - you can't use 
"i" by mistake after the loop).

But I think you need "--std=c99" for gcc to take that.

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Using C99 in the kernel was Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
    • From: Andi Kleen <[email protected]>

• Prev by Date: NMI watchdog logic on X86-64
• Next by Date: Re: Semantics of smp_mb() [was : Re: [PATCH] Fix RCU race in access of nohz_cpu_mask ]
• Previous by thread: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
• Next by thread: Using C99 in the kernel was Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]