On Mon, Dec 12, 2005 at 10:38:15AM +0100, David Woodhouse wrote: > On Sun, 2005-12-11 at 20:31 +0100, Adrian Bunk wrote: > > Either the depency of MTD_OBSOLETE_CHIPS on BROKEN is correct (in > > which case CONFIG_MTD_OBSOLETE_CHIPS=y wouldn't bring you anything), > > or the dependency on BROKEN is not correct and should be corrected. > > > > David, can you comment on this issue? > > I don't see any justification for MTD_OBSOLETE_CHIPS depending on > BROKEN. That option covers a few of the obsolete chip drivers which > people shouldn't be using any more -- and I'm perfectly willing to > believe that one or two of those don't work any more, but if that's the > case then those individual drivers ought to be marked BROKEN (or just > removed). We shouldn't mark MTD_OBSOLETE_CHIPS broken. >... Two of them don't even compile any more. The patch below removes them and all code depending on them and makes the remaining one (MTD_SHARP) compilable again. > dwmw2 cu Adrian <-- snip --> MTD_OBSOLETE_CHIPS shouldn't be marked as BROKEN. This patch brings the MTD_SHARP driver back into life and removes the non-compiling MTD_AMDSTD and MTD_JEDEC with everything depending on them. Signed-off-by: Adrian Bunk <[email protected]> <-- snip --> Due to it's size, the patch is attached gzip'ed. arch/cris/arch-v10/drivers/Kconfig | 1 arch/cris/arch-v10/drivers/axisflashmap.c | 3 arch/cris/arch-v32/drivers/Kconfig | 1 arch/cris/arch-v32/drivers/axisflashmap.c | 3 drivers/mtd/chips/Kconfig | 22 drivers/mtd/chips/Makefile | 2 drivers/mtd/chips/amd_flash.c | 1403 ---------------------- drivers/mtd/chips/jedec.c | 935 -------------- drivers/mtd/maps/Kconfig | 18 drivers/mtd/maps/Makefile | 2 drivers/mtd/maps/octagon-5066.c | 248 --- drivers/mtd/maps/vmax301.c | 198 --- include/linux/mtd/jedec.h | 66 - 13 files changed, 1 insertion(+), 2901 deletions(-)
Attachment:
patch-MTD_OBSOLETE_CHIPS.gz
Description: Binary data
- References:
- [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
- From: Adrian Bunk <[email protected]>
- Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
- From: Russell King <[email protected]>
- Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
- From: Adrian Bunk <[email protected]>
- Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
- From: David Woodhouse <[email protected]>
- [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
- Prev by Date: [PATCH] natsemi: NAPI support
- Next by Date: [2.6 patch] drivers/mtd/: small cleanups
- Previous by thread: Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
- Next by thread: Re: [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y
- Index(es):
 |