Re: [DOC PATCH] block/stat.txt

[Jens Axboe <axboe@suse.de>]

On Sat, Dec 10 2005, Andy Isaacson wrote:
> I couldn't find any docs explaining the contents of
> /sys/block/<dev>/stat, so I wrote up the following.  I'm not completely
> sure it's accurate - Jens, could you give a yea or nay on this?
> 
> In particular, the counts of read/write IOs and read/write sectors are
> incremented in different places - it looks like they both increment as
> the request is being finished, but I'm not completely sure of that.

Overall it looks very nice, you basically all of it right. And thanks
for doing it btw, it's a good addition to the documentation. A few small
comments follows:


> +Name            units         description
> +----            -----         -----------
> +read I/Os       requests      number of read I/Os processed
> +read merges     requests      number of read I/Os merged with in-queue I/O
> +read sectors    blocks        number of sectors read

The unit here should just read 'sectors', blocks usually refers to a
file system block.

> +read I/Os, write I/Os
> +=====================
> +
> +These values increment when an I/O request completes.
> +
> +read merges, write merges
> +=========================
> +
> +These values increment when an I/O request is merged with an
> +already-queued I/O request.

Both correct, good!

> +read sectors, write sectors
> +===========================
> +
> +These values count the number of blocks read from or written to this
> +block device.  The "blocks" in question are the standard UNIX 512-byte
> +blocks, not any device-specific block size.  The counters are
> +incremented when the I/O completes.

These standard 512-b blocks we just call sectors in Linux.

> +in_flight
> +=========
> +
> +This value counts the number of currently-queued I/O requests.

A little confusing - it's the number of in flight io at the
driver/device end, that is after the block layer. One could read the
above as total in flight (total queued in the queue for the device),
which is a very different number.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/