Re: [PATCH] Cpuset: rcu optimization of page alloc hook

Paul Jackson a écrit :

+
+static kmem_cache_t *cpuset_cache;
+


Hi Paul

Please do use __read_mostly for new kmem_cache :

static kmem_cache_t *cpuset_cache __read_mostly;

If not, the pointer can sit in the midle of a highly modified cache line, andmultiple CPUS will have memory cache misses to access the cpuset_cache, whileslab code/data layout itself is very NUMA/SMP friendly.


Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] Cpuset: rcu optimization of page alloc hook
  - From: Paul Jackson <[email protected]>
- Re: [PATCH] Cpuset: rcu optimization of page alloc hook
  - From: Nick Piggin <[email protected]>

References:
- [PATCH] Cpuset: rcu optimization of page alloc hook
  - From: Paul Jackson <[email protected]>

Prev by Date: [PATCH] Cpuset: rcu slab cache optimization rcu_dereference comment
Next by Date: Re: set_page_dirty vs set_page_dirty_lock
Previous by thread: Re: [PATCH] Cpuset: rcu optimization of page alloc hook
Next by thread: Re: [PATCH] Cpuset: rcu optimization of page alloc hook
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]