Re: [patch 1/2] Add platform_device_del()

Hi Dmirty,

> Driver core: add platform_device_del function
> 
> Having platform_device_del90 allows more straightforward error
> handling code in drivers registering platform devices.
> (...)
> +/**
> + *	platform_device_unregister - unregister a platform-level device
> + *	@pdev:	platform device we're unregistering
> + *
> + *	Unregistration is done in 2 steps. Fisrt we release all resources
> + *	and remove it from the sybsystem, then we drop reference count by

Typo: subsystem.

> + *	calling platform_device_put().
> + */

Other than that, and let alone the fact that I prefer code cleanups as
separate patches, and the fact that I don't think moving
platform_device_register() around adds much value, this patch looks
good to me.

Thanks,
-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 1/2] Add platform_device_del()
    • From: Dmitry Torokhov <[email protected]>

• References:
  • [patch 0/2] Add platform_device_del()
    • From: Dmitry Torokhov <[email protected]>
  • [patch 1/2] Add platform_device_del()
    • From: Dmitry Torokhov <[email protected]>

• Prev by Date: Re: GNU/Linux in a binary world... a doomsday scenario
• Next by Date: Re: RFC: Starting a stable kernel series off the 2.6 kernel
• Previous by thread: [patch 1/2] Add platform_device_del()
• Next by thread: Re: [patch 1/2] Add platform_device_del()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]