Re: [PATCH 2/3] i386: CS5535 chip support - GPIO

Ben Gardner <[email protected]> wrote:
>
> +/* These are defined in cs5535.c */
> +extern u32 cs5535_gpio_base;
> +extern u32 cs5535_gpio_mask;

And they should be declared in a header file, please.

Is there a reason for these being exported to non-GPL modules, or can they
be EXPORT_SYMBOL_GPL()?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2/3] i386: CS5535 chip support - GPIO
    • From: Ben Gardner <[email protected]>

• Prev by Date: Re: [patch] add two inotify_add_watch flags
• Next by Date: Re: PowerBook5,8 - TrackPad update
• Previous by thread: [PATCH 2/3] i386: CS5535 chip support - GPIO
• Next by thread: [PATCH 3/3] i386: CS5535 chip support - SMBus
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]