Re: [RFC][PATCH 2/3]i386,x86-64 Handle missing local APIC timer interrupts on C3 state

On Fri, Dec 09, 2005 at 07:07:39PM +0100, Andi Kleen wrote:
> Just a quick comment - didn't review the full patch.
> 
> > +#ifdef ARCH_APICTIMER_STOPS_ON_C3
> > +			if (c->x86_vendor == X86_VENDOR_INTEL) {
> > +				on_each_cpu(switch_APIC_timer_to_ipi, 
> > +						&mask, 1, 1);
> > +			}
> > +#endif
> 
> Better make it a runtime variable instead of an ifdef with a boot option.
> I found at least one non Intel system so far with the same issue
> (although it wasn't multi processor) 

Actually, that particular ifdef ARCH_APICTIMER_STOPS_ON_C3 is always set for
i386 and x86-64 and local APIC is enabled. I only added that ifdef to skip 
this code for IA-64, which can also use acpi processor_idle.c.

For any other CPU in i386 or x86-64, we can just add runtime check along with
VENDOR_INTEL. 

Thanks,
Venki


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH 2/3]i386,x86-64 Handle missing local APIC timer interrupts on C3 state
    • From: Venkatesh Pallipadi <[email protected]>
  • Re: [RFC][PATCH 2/3]i386,x86-64 Handle missing local APIC timer interrupts on C3 state
    • From: Zwane Mwaikambo <[email protected]>
  • Re: [RFC][PATCH 2/3]i386,x86-64 Handle missing local APIC timer interrupts on C3 state
    • From: Venkatesh Pallipadi <[email protected]>
  • Re: [RFC][PATCH 2/3]i386,x86-64 Handle missing local APIC timer interrupts on C3 state
    • From: Zwane Mwaikambo <[email protected]>
  • Re: [RFC][PATCH 2/3]i386,x86-64 Handle missing local APIC timer interrupts on C3 state
    • From: Venkatesh Pallipadi <[email protected]>
  • Re: [RFC][PATCH 2/3]i386,x86-64 Handle missing local APIC timer interrupts on C3 state
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [discuss] [patch] x86_64: align and pad x86_64 GDT on page boundary
• Next by Date: Re: [patch] add two inotify_add_watch flags
• Previous by thread: Re: [RFC][PATCH 2/3]i386,x86-64 Handle missing local APIC timer interrupts on C3 state
• Next by thread: Re: [RFC][PATCH 2/3]i386,x86-64 Handle missing local APIC timer interrupts on C3 state
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]