On Dec 9, 2005, at 11:05 AM, Adam Litke wrote:
On Fri, 2005-12-09 at 10:39 -0600, Mark Rustad wrote:
This patch makes the function make_huge_pte non-static, so it can
be used
by drivers that want to mmap huge pages. Consequently, a prototype
for the
function is added to hugetlb.h. Since I was looking here, I
noticed some
coding style problems in the function and fix them with this patch.
Signed-off-by: Mark Rustad <[email protected]>
Call me crazy, but I cringe when I think of any old driver directly
mucking with huge_ptes. Forgive me if I am missing something, but why
can't you just call do_mmap with a hugetlbfs file like everyone else?
Otherwise, the CodingStyle cleanups look alright.
That would be nice, but we need multiple, contiguous huge pages.
Actually, about 768M worth. Yeah, I guess I'll stipulate that what
we're doing is pretty crazy, but it works well. I figure if I can
call alloc_huge_page, I should be able to remap such a page.
Actually, I would prefer an explicit remap call for this purpose, but
in doing my own I found that I needed precisely the code that was
already in make_huge_pte.
I don't have any strong feeling about whether this is accepted or
not. I just thought that I should share a change that might be useful
to others.
--
Mark Rustad, [email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
