Re: [PATCH] Decrease number of pointer derefs in nf_conntrack_core.c

[Jesper Juhl <jesper.juhl@gmail.com>]

On 12/9/05, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Jesper Juhl <jesper.juhl@gmail.com> wrote:
>
> > orig:
> >    text    data     bss     dec     hex filename
> >   12636      49     760   13445    3485 net/netfilter/nf_conntrack_core.o
> >
> > patched:
> >    text    data     bss     dec     hex filename
> >   11825     183     632   12640    3160 net/netfilter/nf_conntrack_core.o
>
> just a question - are you sure the measurements are accurate in this
> case? The patch looks too small to shave more than 800 bytes off .text!
> If it's real then something really wrong is going on in gcc-land ...
>
I did all this with an allyesconfig kernel source and then did :
   make net/netfilter/nf_conntrack_core.o
   size net/netfilter/nf_conntrack_core.o
   rm net/netfilter/nf_conntrack_core.o
then applied the patch and redid
   make net/netfilter/nf_conntrack_core.o
   size net/netfilter/nf_conntrack_core.o

So I believe the numbers should be correct, but I'm not at home atm,
so I can't verify right now. I won't have a chance to look at it until
tomorrow, but then I'll double-check.

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/