Re: [ACPI] ACPI owner_id limit too low

[Carl-Daniel Hailfinger <c-d.hailfinger.devel.2005@gmx.net>]

Alex Williamson schrieb:
>    We've found recently that it's not very hard to bump into the limit
> of the number of owner_ids that the ACPI subsystem can provide.
> [...] Doubling the limit to 64 is a sufficient short term fix
> and a fairly trivial patch, maybe even something that could go in before
> 2.6.15.  Len, could we do something like the below patch to give us a
> little more reasonable limit?  We could switch to a bitmap too, but
> given how close the next kernel is to release this is less impact.
> Thanks,
>
> 	Alex
>
>
> Signed-off-by: Alex Williamson <alex.williamson@hp.com>
> ---
>
> diff -r 03055821672a drivers/acpi/utilities/utmisc.c
> --- a/drivers/acpi/utilities/utmisc.c	Mon Dec  5 01:00:10 2005
> +++ b/drivers/acpi/utilities/utmisc.c	Wed Dec  7 14:55:58 2005
> @@ -84,14 +84,14 @@
>  
>  	/* Find a free owner ID */
>  
> -	for (i = 0; i < 32; i++) {
> -		if (!(acpi_gbl_owner_id_mask & (1 << i))) {
> +	for (i = 0; i < 64; i++) {
> +		if (!(acpi_gbl_owner_id_mask & (1UL << i))) {

Shouldn't this be 1ULL if you intend it to be 64 bit wide on a
32 bit arch?


Regards,
Carl-Daniel
--
http://www.hailfinger.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/