Re: [PATCH 12/16] mm: fold sc.may_writepage and sc.may_swap into sc.flags

Wu Fengguang wrote:

On Wed, Dec 07, 2005 at 09:36:23PM +1100, Nick Piggin wrote:

Wu Fengguang wrote:

Fold bool values into flags to make struct scan_control more compact.

Probably not a bad idea (although you haven't done anything for 64-bit
archs, yet)... do we wait until one more flag wants to be added?

I did this to hold some more debug flags :)

Yes, but if they make sense for the current kernel too, it reduces
the peripheral noise out of your patchset... which helps everyone :)

I'll make it a standalone patch, too.

Thanks. I don't have strong feelings either way, but I had always
been meaning to do something like this if we picked up another flag.

--
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com -

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 12/16] mm: fold sc.may_writepage and sc.may_swap into sc.flags
    • From: Wu Fengguang <[email protected]>

• References:
  • [PATCH 00/16] Balancing the scan rate of major caches V3
    • From: Wu Fengguang <[email protected]>
  • [PATCH 12/16] mm: fold sc.may_writepage and sc.may_swap into sc.flags
    • From: Wu Fengguang <[email protected]>
  • Re: [PATCH 12/16] mm: fold sc.may_writepage and sc.may_swap into sc.flags
    • From: Nick Piggin <[email protected]>
  • Re: [PATCH 12/16] mm: fold sc.may_writepage and sc.may_swap into sc.flags
    • From: Wu Fengguang <[email protected]>

• Prev by Date: Re: [patch 00/21] hrtimer - High-resolution timer subsystem
• Next by Date: [PATCH 2.6.15-rc5-mm1] m32r: Fix M32104 cache flushing routines
• Previous by thread: Re: [PATCH 12/16] mm: fold sc.may_writepage and sc.may_swap into sc.flags
• Next by thread: Re: [PATCH 12/16] mm: fold sc.may_writepage and sc.may_swap into sc.flags
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]