Re: Linux 2.6.15-rc4

[Linus Torvalds <torvalds@osdl.org>]

On Thu, 1 Dec 2005, Felipe Alfaro Solana wrote:
> 
> Exactly that's what I'm seeing with the propietary nVidia driver:

Does yours work despite the messages?

Also, can both of you apply this debugging patch that just adds a bit more 
information about exactly what kind of mapping these drivers are trying to 
do..

		Thanks,
			Linus

---
diff --git a/mm/memory.c b/mm/memory.c
index 4b4fc3a..b0ab902 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1241,22 +1241,33 @@ static int incomplete_pfn_remap(struct v
 
 	if (!(vma->vm_flags & VM_INCOMPLETE)) {
 		if (warn) {
+			unsigned long val = pgprot_val(prot);
 			warn--;
 			printk("%s does an incomplete pfn remapping", current->comm);
+			printk("vma: %lx-%lx remap: %lx-%lx pfn: %lx, prot: %lx",
+				vma->vm_start, vma->vm_end,
+				start, end,
+				pfn, val);
 			dump_stack();
 		}
 	}
 	vma->vm_flags |= VM_INCOMPLETE | VM_IO | VM_RESERVED;
 
-	if (start < vma->vm_start || end > vma->vm_end)
+	if (start < vma->vm_start || end > vma->vm_end) {
+		printk("pfn remap outside the vma!\n");
 		return -EINVAL;
+	}
 
-	if (!pfn_valid(pfn))
+	if (!pfn_valid(pfn)) {
+		printk("incomplete pfn remap with IO pages not supported\n");
 		return -EINVAL;
+	}
 
 	page = pfn_to_page(pfn);
-	if (!PageReserved(page))
+	if (!PageReserved(page)) {
+		printk("incomplete pfn remap with non-reserved pages!??!\n");
 		return -EINVAL;
+	}
 
 	retval = 0;
 	while (start < end) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/