Re: [PATCH 2.6-git] SPI core refresh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark Underwood wrote:

However, there also are some advantages of our core compared to David's I'd like to mention

- it can be compiled as a module
So can David's. You can use BIOS tables in which case you must compile the SPI core into the
kernel but you can also use spi_new_device which allows the SPI core to be built as a module (and
is how I am using it).
You limit the functionality, so it's not the case.

- it is DMA-safe
To my understanding David's core is DMA-safe. Yes there is a question mark over one of the helper
functions, but the _main_ functions _are_ DMA-safe.
Yeah, I can agree with this statement. However, as it turns out, the latest David's core eliminates this issue.

- it is priority inversion-free
- it can gain more performance with multiple controllers
Sorry I'm not sure what you mean here.
If there's more than one SPI controller onboard, spi_write_then_read will serialize the transfers related to two different controllers what will have significant negative impact on the transfer speed (so DMA won't help increasing the speed in this case). Moreover, if, say, two kernel threads with different priorities are working with two SPI controllers respectively *priority inversion* will happen. You might also want to learn more about real-time systems characterictics such as priority inversion, BTW.

- it's more adapted for use in real-time environments
- it's not so lightweight, but it leaves less effort for the bus driver developer.

But also less flexibility. A core layer shouldn't _force_ a policy
Nope, it's just a default policy.

on a bus driver. I am currently developing an adapter driver for David's system and I wouldn't say
that the core is making me do things I think the core should do. Please could you provide examples
of where you think Davids SPI core requires 'effort'.
Main are
- the need to call 'complete' in controller driver
- the need to implement policy in controller driver

Vitaly
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux