-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
There seems to be a small bug in inet_connection_sock.c: the lowest port
set using sysctl (taken from 'sysctl_local_port_range') is always
skipped in the first iteration.
In inet_csk_get_port one can find this:
if (hashinfo->port_rover < low)
rover = low;
else
rover = hashinfo->port_rover;
do {
rover++;
As you can see the first statement is a ++ causing the first port to
always be skipped.
Patch fixing this follows below.
Signed off: Folkert van Heusden <[email protected]>
diff -uNbB inet_connection_sock.c.org inet_connection_sock.c
- --- inet_connection_sock.c.org 2005-11-21 18:52:24.000000000 +0100
+++ inet_connection_sock.c 2005-11-21 18:53:43.000000000 +0100
@@ -86,7 +86,6 @@
else
rover = hashinfo->port_rover;
do {
- - rover++;
if (rover > high)
rover = low;
head = &hashinfo->bhash[inet_bhashfn(rover, hashinfo->bhash_size)];
@@ -97,6 +96,7 @@
break;
next:
spin_unlock(&head->lock);
+ rover++;
} while (--remaining > 0);
hashinfo->port_rover = rover;
spin_unlock(&hashinfo->portalloc_lock);
Folkert van Heusden
- --
Try MultiTail! Multiple windows with logfiles, filtered with regular
expressions, colored output, etc. etc. www.vanheusden.com/multitail/
- ----------------------------------------------------------------------
Get your PGP/GPG key signed at www.biglumber.com!
- ----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iIMEARECAEMFAkOCC7A8Gmh0dHA6Ly93d3cudmFuaGV1c2Rlbi5jb20vZGF0YS1z
aWduaW5nLXdpdGgtcGdwLXBvbGljeS5odG1sAAoJEDAZDowfKNiuqb0AniaoetnQ
NwtInW+Af7nEsTxXCraBAJ9xU15UVTg3RIewulXU2kFLr9viFQ==
=bJdc
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
