Re: [PATCH] slab: minor cleanup to kmem_cache_alloc_node

On Mon, 21 Nov 2005, Pekka J Enberg wrote:

> This patch gets rid of one if-else statement by moving current node allocation
> check at the beginning of kmem_cache_alloc_node().

The problem with this is that the numa_node may change if irqs are still 
active and your patch moves the check for the numa node outside of the 
section where irqs are enabled.

You could move the check for -1 into the section where interrupts are 
disabled.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] slab: minor cleanup to kmem_cache_alloc_node
    • From: Pekka Enberg <[email protected]>

• References:
  • [PATCH] slab: minor cleanup to kmem_cache_alloc_node
    • From: Pekka J Enberg <[email protected]>

• Prev by Date: [PATCH] Shut up warnings in ipc/shm.c
• Next by Date: Re: disable tsc with seccomp
• Previous by thread: Re: [PATCH] slab: minor cleanup to kmem_cache_alloc_node
• Next by thread: Re: [PATCH] slab: minor cleanup to kmem_cache_alloc_node
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]