Re: I made a patch and would like feedback/testers (drivers/cdrom/aztcd.c)

[Con Kolivas <kernel@kolivas.org>]

On Mon, 21 Nov 2005 19:42, Daniel Marjamäki wrote:
> Con Kolivas wrote:
> > Convention in the kernel would be
> > 	aztTimeOut =  HZ / 100 ? : 1;
> > to be at least one tick (works for HZ even below 100) and is at least
> > 10ms. If you wanted 2 ms then use
> > 	aztTimeOut =  HZ / 500 ? : 1;
> > which would give you at least 2ms
>
> Thank you Con for the feedback.
>
> Hmm.. The minimum value should be 2, right?
> Otherwise the loop could time out after only a few nanoseconds.. since the
> loop will then timeout immediately on a clock tick. Or am I wrong?

 	aztTimeOut =  HZ / 500 ? : 1;
Would give you a 2ms timeout on 1000Hz and 500Hz
It would give you 5ms on 250Hz and 10ms on 100Hz

ie the absolute minimum it would be would be 2ms, but it would always be at 
least one timer tick which is longer than 2ms at low HZ values.

Cheers,
Con
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/