Re: [RFC][PATCH 2/8] Create emergency trigger

Paul Jackson wrote:
>>@@ -876,6 +879,16 @@ __alloc_pages(gfp_t gfp_mask, unsigned i
>> 	int can_try_harder;
>> 	int did_some_progress;
>> 
>>+	if (is_emergency_alloc(gfp_mask)) {
> 
> 
> Can this check for is_emergency_alloc be moved lower in __alloc_pages?
> 
> I don't see any reason why most __alloc_pages() calls, that succeed
> easily in the first loop over the zonelist, have to make this check.
> This would save one conditional test and jump on the most heavily
> used code path in __alloc_pages().

Good point, Paul.  Will make sure that gets moved.

Thanks!

-Matt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH 0/8] Critical Page Pool
    • From: Matthew Dobson <[email protected]>
  • [RFC][PATCH 2/8] Create emergency trigger
    • From: Matthew Dobson <[email protected]>
  • Re: [RFC][PATCH 2/8] Create emergency trigger
    • From: Paul Jackson <[email protected]>

• Prev by Date: Re: [RFC][PATCH 1/8] Create Critical Page Pool
• Next by Date: Re: [RFC][PATCH 0/8] Critical Page Pool
• Previous by thread: Re: [RFC][PATCH 2/8] Create emergency trigger
• Next by thread: [RFC][PATCH 4/8] Fix a bug in scsi_get_command
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]