[2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer dereference

The Coverity checker spotted this obvious NULL pointer dereference 
caused by a wrong order of the cleanups.


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.15-rc1-mm2-full/drivers/infiniband/core/mad.c.old	2005-11-20 22:04:36.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/infiniband/core/mad.c	2005-11-20 22:05:17.000000000 +0100
@@ -355,9 +355,9 @@
 	spin_unlock_irqrestore(&port_priv->reg_lock, flags);
 	kfree(reg_req);
 error3:
-	kfree(mad_agent_priv);
-error2:
 	ib_dereg_mr(mad_agent_priv->agent.mr);
+error2:
+	kfree(mad_agent_priv);
 error1:
 	return ret;
 }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [stable] [2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer dereference
  - From: Greg KH <[email protected]>

Prev by Date: [2.6 patch] drivers/ieee1394/csr1212.c: remove dead code
Next by Date: [2.6 patch] video/matrox/matroxfb_misc.c: remove dead code
Previous by thread: [2.6 patch] drivers/ieee1394/csr1212.c: remove dead code
Next by thread: Re: [stable] [2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer dereference
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]