Re: [PATCH] Fix race in set_max_huge_pages for multiple updaters of nr_huge_pages

On Fri, Nov 18, 2005 at 07:09:50PM -0800, Andrew Morton wrote:
> Nope, alloc_fresh_huge_page() does a GFP_HIGHUSER allocation, which can
> sleep and may not be called inside spinlock.  You would have seen a spew of
> might_sleep() warnings if this was tested with the appropriate kernel
> debugging options.
> How about this?

Looks good. My reply got stuck behind a queue of other things to do
since it needed a correction.

Acked-by: William Irwin <[email protected]>


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix race in set_max_huge_pages for multiple updaters of nr_huge_pages
    • From: Eric Paris <[email protected]>
  • Re: [PATCH] Fix race in set_max_huge_pages for multiple updaters of nr_huge_pages
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [2.6 patch] i386: always use 4k stacks
• Next by Date: Re: 2.6.15-rc1-mm1
• Previous by thread: Re: [PATCH] Fix race in set_max_huge_pages for multiple updaters of nr_huge_pages
• Next by thread: 2.6.15-rc1-mm1 panic in ptrace_check_attach()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]