Re: PATCH: Fix poor pointer math in devinet_sysctl_register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Andrew Morton <[email protected]>
Date: Wed, 16 Nov 2005 22:14:12 -0800

> "Jordan Crouse" <[email protected]> wrote:
> >  @@ -1454,7 +1454,7 @@ static void devinet_sysctl_register(stru
> >   		return;
> >   	memcpy(t, &devinet_sysctl, sizeof(*t));
> >   	for (i = 0; i < ARRAY_SIZE(t->devinet_vars) - 1; i++) {
> >  -		t->devinet_vars[i].data += (char *)p - (char *)&ipv4_devconf;
> >  +		t->devinet_vars[i].data += (int)((char *)p - (char *)&ipv4_devconf);
> 
> Confused.  These appear to be equivalent (on 32-bit CPUs, anyway).

Indeed, please describe the exact failure case when posting
such patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux