Re: [PATCH -rt] race condition in fs/compat.c with compat_sys_ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Steven Rostedt <[email protected]> wrote:

> It's still there in 2.6.15-rc1-git3 (the sem is the down_read of 
> ioctl32_sem in fs/compat.c).
> 
> No, the problem was unique to the rt patch.  In -rt the default 
> down_read is just like a down (since it is very hard to do PI on 
> readers and writer locks).  So the solution in -rt was to convert this 
> back to a normal RW sem.

to be precise: rwsems in PREEMPT_RT are "only one reader, but reader 
might self-recurse". I.e. the sequence of:

	down_read();
	...
		down_read();
		...
		up_read();
	...
	up_read();

is still supported.

this very simple rw-semaphore type covers the overwhelming majority of 
uses: out of hundreds of rwsems in the kernel, ioctl32_sem is the first 
one that had to be converted to a 'compat' rwsem.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux