Re: [PATCH 1/8] isaectomy: toshiba.c

[Al Viro <viro@ftp.linux.org.uk>]

On Tue, Nov 15, 2005 at 08:03:19PM -0800, Linus Torvalds wrote:
> Hmm.. I actually believe that the isa_read() functions are more portable 
> and easier to use than ioremap().
> 
> The reason? A platform will always know where any legacy ISA bus resides, 
> while the "ioremap()" thing will depend on platform PCI code to have set 
> the right offsets (and thus the resource addresses) for whatever bus the 
> PCI device is on.
> 
> So doing a "ioremap(0xf0000)" is actually a harder operation at run-time 
> when you have to basically have some special case ("is this address range 
> in the ISA legacy region") than for the platform code to just always map 
> the ISA legacy region at some random offset and then doing "isa_read()" 
> from that.
> 
> Is there some underlying reason you want to remove the isa_xxx stuff?

The fact that it has almost no users?  And nearly all drivers that do
use it (and not just have it in dead code) are using it for access to
very specific locations in BIOS...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/