Re: [PATCH] hugepages: fold find_or_alloc_pages into huge_no_page()

On Tue, 2005-11-15 at 13:47 -0800, Christoph Lameter wrote:
> The number of parameters for find_or_alloc_page increases significantly after
> policy support is added to huge pages. Simplify the code by folding
> find_or_alloc_huge_page() into hugetlb_no_page().
> 
> Adam Litke objected to this piece in an earlier patch but I think this is a
> good simplification. Diffstat shows that we can get rid of almost half of the
> lines of find_or_alloc_page(). If we can find no consensus then lets simply drop
> this patch.

Okay.  Since I am the only objector I'll be willing to back down if
we're sure find_or_alloc_huge_page() has no extra value as a separate
function.  Five parameters is getting a bit unwieldy and suggests it's
usefulness outside of hugetlb_no_page() is near zero.

-- 
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] hugepages: fold find_or_alloc_pages into huge_no_page()
    • From: Christoph Lameter <[email protected]>

• Prev by Date: Re: [PATCH]small fix for __ipv6_addr_type(...)
• Next by Date: Re: [Patch 1/4] Delay accounting: Initialization
• Previous by thread: [PATCH] hugepages: fold find_or_alloc_pages into huge_no_page()
• Next by thread: pfn_to_nid under CONFIG_SPARSEMEM and CONFIG_NUMA
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]