Re: [PATCH ] Fix some problems with truncate and mtime semantics.

> Finally, if vmtruncate succeeds, and ATTR_SIZE is the only change
> requested, we now fall-through and mark_inode_dirty.  If a filesystem
> did not have a ->truncate function, then vmtruncate will have changed
> i_size, without marking the inode as 'dirty', and I think this is wrong.

And if filesystem does not have a ->truncate() function and it caller
was [f]truncate(), ctime and mtime won't be set.

That's wrong too, isn't it?

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH ] Fix some problems with truncate and mtime semantics.
    • From: Neil Brown <[email protected]>

• References:
  • [PATCH ] Fix some problems with truncate and mtime semantics.
    • From: NeilBrown <[email protected]>

• Prev by Date: Re: [PATCH] ppc: Fix boot with yaboot with ARCH=ppc
• Next by Date: Re: [PATCH ] Fix some problems with truncate and mtime semantics.
• Previous by thread: Re: [PATCH ] Fix some problems with truncate and mtime semantics.
• Next by thread: Re: [PATCH ] Fix some problems with truncate and mtime semantics.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]