Re: [PATCH] Allow arch to veto PC speaker beeper initialization

[Christoph Hellwig <hch@infradead.org>]

On Tue, Nov 15, 2005 at 01:02:00PM +1100, Paul Mackerras wrote:
> From: Michael Neuling <mikey@neuling.org>
> 
> This patch provides an arch hook in the PC speaker beeper driver which
> gives the arch code an opportunity to determine whether the machine
> has an i8253 timer or not.  If it doesn't we don't want the driver to
> go poking at the i8253's ports; there might be nothing there or there
> might be something else there which would be upset by being poked at.
> 
> We want to be able to build ppc64 kernels which work both on machines
> that have an i8253 equivalent (e.g. some pSeries) and on machines that
> don't (e.g. G5 powermacs), which is why we don't just remove it from
> the config.

Wrong way around.  The architecture should provide a way to find it, not
to veto it.  It should probably use the plattform_device infrastructure.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/