Re: [PATCH]IPv6: small fix for ipv6_dev_get_saddr(...)

In article <[email protected]> (at Mon, 14 Nov 2005 18:42:30 +0800), Yan Zheng <[email protected]> says:

> The "score.rule++" doesn't make any sense for me. 
> According to codes above, I think it should be "hiscore.rule++;" .

Oops, you're right.

> Signed-off-by: Yan Zheng<[email protected]>
Acked-by: YOSHIFUJI Hideaki <[email protected]>

>  			/* Rule 8: Use longest matching prefix */
> -			if (hiscore.rule < 8)
> +			if (hiscore.rule < 8) {
>  				hiscore.matchlen = ipv6_addr_diff(&ifa_result->addr, daddr);
> -			score.rule++;
> +				hiscore.rule++;
> +			}
>  			score.matchlen = ipv6_addr_diff(&ifa->addr, daddr);
>  			if (score.matchlen > hiscore.matchlen) {
>  				score.rule = 8;
> 

-- 
YOSHIFUJI Hideaki @ USAGI Project  <[email protected]>
GPG-FP  : 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH]IPv6: small fix for ipv6_dev_get_saddr(...)
    • From: "David S. Miller" <[email protected]>

• References:
  • [PATCH]IPv6: small fix for ipv6_dev_get_saddr(...)
    • From: Yan Zheng <[email protected]>

• Prev by Date: Re: + perfmon2-reserve-system-calls.patch added to -mm tree
• Next by Date: Re: [RFC] HOWTO do Linux kernel development
• Previous by thread: [PATCH]IPv6: small fix for ipv6_dev_get_saddr(...)
• Next by thread: Re: [PATCH]IPv6: small fix for ipv6_dev_get_saddr(...)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]