Re: [PATCH 1/4] relayfs: add support for non-relay files

[Tom Zanussi <zanussi@us.ibm.com>]

Christoph Hellwig writes:
 > On Wed, Nov 09, 2005 at 03:50:06PM -0600, Tom Zanussi wrote:
 > > Hi,
 > > 
 > > Currently, the relayfs API only supports the creation of directories
 > > (relayfs_create_dir()) and relay files (relay_open()).  This patch
 > > adds support for non-relay files (relayfs_create_file()).
 > >     
 > > This is so relayfs applications can create 'control files' in relayfs
 > > itself rather than in /proc or via a netlink channel, as is currently
 > > done in the relay-app examples.  There were several comments that the
 > > use of netlink in the example code was non-intuitive and in fact the
 > > whole relay-app business was needlessly confusing.  Based on that
 > > feedback, the example code has been completely converted over to
 > > relayfs control files as supported by this patch, and have also been
 > > made completely self-contained.  The converted examples can be found
 > > here:
 > 
 > NACK.  please do one thing at a time in relayfs instead of adding everthing
 > and a kitchen sink.
 > 

OK, sure.  This isn't a huge patch and everything in it is related to
one logical change, the other one contains a couple of changes and
some cleanup and could easily be broken out, anyway I'll break
everything up into smaller pieces and resubmit.

Tom


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/