On Wed, Nov 09, 2005 at 06:09:27PM +0100, Jan Beulich wrote:
> >>> Greg KH <[email protected]> 09.11.05 17:45:44 >>>
> >#ifdef in the .h file is not needed. Please fix your email client to
> >send patches properly.
>
> It's not needed, sure, but by having it there I just wanted to make
> clear that this is something that never can be called from a module
> (after all, why should one find out at modpost time (and maybe even miss
> the message since there are so many past eventual symbol resolution
> warnings) when one can already at compile time.
If it isn't present, and you do a build, you will still get the error at
build time, just during a different part of it. Adding #ifdef just to
move the error to a different part of the build isn't needed. Remember,
we want to not use #ifdef at all if we can ever help it.
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
