Re: [KJ] [PATCH 6/8] Cleanup slabinfo_write()

On Tue, 8 Nov 2005, Alexey Dobriyan wrote:

> On Mon, Nov 07, 2005 at 04:57:27PM -0800, Matthew Dobson wrote:
> > * Set 'res' at declaration instead of later in the function.
> 
> I hate to initialize a varible two miles away from the place where it's
> used.

 
> > -	int limit, batchcount, shared, res;
> > +	int limit, batchcount, shared, res = -EINVAL;

Looks more confusing than before.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [KJ] [PATCH 6/8] Cleanup slabinfo_write()
    • From: Matthew Dobson <[email protected]>

• References:
  • [PATCH 0/8] Cleanup slab.c
    • From: Matthew Dobson <[email protected]>
  • [PATCH 6/8] Cleanup slabinfo_write()
    • From: Matthew Dobson <[email protected]>
  • Re: [KJ] [PATCH 6/8] Cleanup slabinfo_write()
    • From: Alexey Dobriyan <[email protected]>

• Prev by Date: Re: [PATCH 0/8] Cleanup slab.c
• Next by Date: Re: [PATCH 8/8] Inline 3 functions
• Previous by thread: Re: [KJ] [PATCH 6/8] Cleanup slabinfo_write()
• Next by thread: Re: [KJ] [PATCH 6/8] Cleanup slabinfo_write()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]