Re: [dm-devel] [2.6 patch] drivers/md/kcopyd.c: remove kcopyd_cancel()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 08, 2005 at 02:44:19PM +0100, Adrian Bunk wrote:
> A function that is
> - not used
> - empty
> - without a prototype in any header file
> should be removed.
 
I'd rather you submitted a patch to complete the function and invoke it
in the appropriate place:-)  But please don't remove comments indicating 
missing functionality: commenting it out till it's written would be better.

Alasdair
-- 
[email protected]

> -/*
> - * Cancels a kcopyd job, eg. someone might be deactivating a
> - * mirror.
> - */
> -int kcopyd_cancel(struct kcopyd_job *job, int block)
> -{
> -	/* FIXME: finish */
> -	return -1;
> -}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux