On Tue, 2005-11-08 at 12:36 +0100, Takashi Iwai wrote:
[...]
> Note that "goto done" may
> require the lock again. Also, the succeeding saa7134_dma_stop() is
> superfluous.
>
No, it's not. dma_stop also affects the main saa7134 module, and it's
needed there.
[...]
> @@ -973,18 +963,17 @@ int alsa_card_saa7134_create (struct saa
> > chip->irq = saadev->pci->irq;
> > chip->iobase = pci_resource_start(saadev->pci, 0);
> >
> > - err = request_irq(chip->pci->irq, saa7134_alsa_irq,
> > + err = request_irq(saadev->pci->irq, saa7134_alsa_irq,
> > SA_SHIRQ | SA_INTERRUPT, saadev->name, saadev);
>
> Hmm, still I don't see any call of free_irq() in the driver?
>
It was added to v4l CVS shortly after Mauro sent the last patchset,
should be sent upstream in the next patchset.
[...]
--
RC
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
