Re: [PATCH 06/25] mtd: move ioctl32 code to mtdchar.c

On Sat, 5 November 2005 17:26:56 +0100, Arnd Bergmann wrote:
> 
> The MTD ioctls are all specific to mtdchar.c, so the
> compat code for them should be there as well.
> 
> Also, some of the ioctl commands used in that driver
> were previously not marked as compatible.
> 
> The conversion handlers could be further simplified
> by not using compat_alloc_user_space any more.
> 
> CC: [email protected]
> CC: [email protected]
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Jörn Engel <[email protected]>

Moving crap over to mtdchar.c is a good thing.  Complete removal of
mtdchar.c might be even better, but at least the crap is relatively
self-contained now.

Jörn

-- 
When in doubt, punt.  When somebody actually complains, go back and fix it...
The 90% solution is a good thing.
-- Rob Landley
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 06/25] mtd: move ioctl32 code to mtdchar.c
    • From: [email protected] (Eric W. Biederman)

• References:
  • [PATCH 06/25] mtd: move ioctl32 code to mtdchar.c
    • From: Arnd Bergmann <[email protected]>

• Prev by Date: [PATCH] drm fixup pci gart settings.
• Next by Date: Re: [2.6 patch] sound/drivers/vx/vx_hwdep.c should #include <linux/vmalloc.h>
• Previous by thread: [PATCH 06/25] mtd: move ioctl32 code to mtdchar.c
• Next by thread: Re: [PATCH 06/25] mtd: move ioctl32 code to mtdchar.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]