Re: [-mm patch] drivers/dlm/: possible cleanups

On Fri, Nov 04, 2005 at 01:06:40PM +0100, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - every file should #include the headers containing the prototypes for
>   it's global functions

Including unnecessary headers doesn't sound right.

> - make needlessly global functions static
> - #if 0 the following unused global functions:
>   - device.c: dlm_device_free_devices
>   - lock.c: dlm_remove_from_waiters
>   - lockspace.c: dlm_find_lockspace_name

I've removed the unused functions and added the statics.

Thanks,
Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [-mm patch] drivers/dlm/: possible cleanups
    • From: Adrian Bunk <[email protected]>

• References:
  • [-mm patch] drivers/dlm/: possible cleanups
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: typedefs and structs [was Re: [PATCH 16/42]: PCI: PCI Error reporting callbacks]
• Next by Date: Re: 2.6.14-mm1
• Previous by thread: [-mm patch] drivers/dlm/: possible cleanups
• Next by thread: Re: [-mm patch] drivers/dlm/: possible cleanups
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]